Skip to content

feat(obs): add injection pipeline timing logs#147

Merged
skevetter merged 2 commits into
mainfrom
fbeb/tunnel-inject-timing
Apr 26, 2026
Merged

feat(obs): add injection pipeline timing logs#147
skevetter merged 2 commits into
mainfrom
fbeb/tunnel-inject-timing

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

Adds structured timing logs at key injection milestones to provide visibility into how long injection takes. After the pipe() correctness fixes, machineprovider's 5s inactivity timeout became a concern — these logs make it easy to spot slow injection at a glance.

  • Info-level start/complete bookends in Inject() and runSSHTunnel() (always visible)
  • Debug-level intermediate milestones: handshake complete, payload delivered, SSH client/session created (visible with -v)
  • All durations use time.Since(start) for human-readable elapsed times (e.g. "1.234s")
  • Tests verify timing log lines appear using log.InitTestObserved

Add structured timing logs at key injection milestones so slow
injection is visible at a glance. Info-level start/complete bookends
are always shown; Debug-level intermediate steps (handshake, payload
delivery, SSH client/session creation) appear with -v.
@netlify

netlify Bot commented Apr 26, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 06a2fc4
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69ee2fb960d0290008ecf7db

@coderabbitai

coderabbitai Bot commented Apr 26, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 31 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 31 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9d3555bb-ead9-482b-89b3-66ac76ff2121

📥 Commits

Reviewing files that changed from the base of the PR and between 51a9405 and 06a2fc4.

📒 Files selected for processing (4)
  • pkg/devcontainer/sshtunnel/sshtunnel.go
  • pkg/devcontainer/sshtunnel/sshtunnel_test.go
  • pkg/inject/inject.go
  • pkg/inject/inject_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Replace inline 'injection: complete' logs with a single defer so early
error paths (GenerateScript, os.Pipe, context.Canceled) are also
covered. Add 'tunnel: setup complete' bookend via defer in runSSHTunnel.
@skevetter
skevetter merged commit 6773838 into main Apr 26, 2026
47 checks passed
@skevetter
skevetter deleted the fbeb/tunnel-inject-timing branch April 26, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant